Fix minor panda update mistakes #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When recently updating panda to v7 in commit ce58764, I followed the example in https://github.com/guardian/tagmanager/pull/535/files#r1767036487 slightly too closely, replacing the use of the config key with a hard-coded string by mistake. This commit restores the use of the config key, and removes a config key that that commit removed the only use of.
waisingyiu
approved these changes
Jan 30, 2025
prout-bot
added
Pending-on-WORKFLOW_PROD
Seen-on-WORKFLOW_PROD
and removed
Pending-on-WORKFLOW_PROD
labels
|
Seen on WORKFLOW_PROD (merged by @emdash-ie 5 minutes and 18 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
When recently updating panda to v7 in commit ce58764 (PR #489), I followed the example in https://github.com/guardian/tagmanager/pull/535/files#r1767036487 slightly too closely, replacing the use of the config key with a hard-coded string by mistake.
This PR restores the use of the config key, and removes a config key that that commit removed the only use of.